Support incomplete parsing#5764
Conversation
|
This brings the project a step closer to having a single REPL implementation! There's still some deficiencies in the stdlib parser for parsing blocks for functions/classes though. |
aneeshdurg
force-pushed
the
incomplete_error
branch
from
e531ae9 to
4b4e178
Compare
|
Fixed |
aneeshdurg
force-pushed
the
incomplete_error
branch
from
719309f to
f2b2225
Compare
|
@youknowone this should be ready for your review now |
| if source.endswith(":") and "expected an indented block" in strerr: | ||
| return None | ||
| elif "incomplete input" in str(e): | ||
| if isinstance(e, _IncompleteInputError): |
There was a problem hiding this comment.
Does this work? Then partially reverting #5743 to the original code will be better, including the upper comment.
| if isinstance(e, _IncompleteInputError): | |
| if "incomplete input" in str(e): |
There was a problem hiding this comment.
That doesn't work, since _IncompleteInputError doesn't necessarily have that string in the error. I've removed the comment and changed this block to just match python 3.15's implementation at least.
youknowone
left a comment
youknowone
left a comment
There was a problem hiding this comment.
looks good, thank you so much!
2 participants
This PR adds support for incomplete parsing both in the native REPL and in the stdin REPL (in particular multiline input support is expanded for to allow more cases such as multiline strings). The implementation adds compatibility for cpython's
PY_CF_ALLOW_INCOMPLETE_INPUTcompile flag and adds a new exception type similar to python 3.14.