Implement nt.listvolumes #5730
Closed
Implement nt.listvolumes #5730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arihant2math
force-pushed
the
more-os
branch
2 times, most recently
from
bfcd5ab to
679af3f
Compare
Member
|
|
youknowone
reviewed
Apr 28, 2025
Member
youknowone
left a comment
youknowone
left a comment
There was a problem hiding this comment.
was there any related test for listvolumes?
Collaborator
Author
Yes, but it requires a different os function that doesn't exist, so it still fails. |
youknowone
reviewed
Apr 30, 2025
| #[pyfunction] | ||
| fn listvolumes(vm: &VirtualMachine) -> PyResult<PyListRef> { | ||
| let mut volumes = vec![]; | ||
| let mut buffer = [0u16; 257]; |
Member
There was a problem hiding this comment.
If it is related to constant, is this possible?
Suggested change
| let mut buffer = [0u16; 257]; | |
| let mut buffer = [0u16; MAX_PATH + 1]; |
Member
|
Thanks! #6373 added it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nt.listvolumesnt._path_existsand similar