Now passing test_math from 3.13.2 with some caveat#5610
Merged
youknowone merged 1 commit intoRustPython:mainfrom Apr 5, 2025
Merged
Now passing test_math from 3.13.2 with some caveat#5610youknowone merged 1 commit intoRustPython:mainfrom
youknowone merged 1 commit intoRustPython:mainfrom
Conversation
4dd3ff8 to
594a330
Compare
youknowone
reviewed
Mar 24, 2025
Member
|
I am a bit confused by the libc vs musl situation. Which version fits to CPython behavior? Does CPython follow musl implementation? |
Contributor
Author
|
CPython uses the system's libm, so on most system its probably going to be libc's libm. Meanwhile, the Rust's libm is based on musl's libm. |
youknowone
requested changes
Mar 31, 2025
ee05a75 to
7191aae
Compare
Implemnted fma in math module.
7191aae to
af42192
Compare
Shakil582
pushed a commit
to Shakil582/RustPython
that referenced
this pull request
Apr 6, 2025
Implemnted fma in math module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are incompatibilities in the implementation of fma from libc vs musl.
I have added the tests that shows the differences here,