Skip to content

Remove winapi dependency and upgrade windows-sys to 0.59#5581

Merged
coolreader18 merged 8 commits into
RustPython:mainfrom
arihant2math:no-winapi
Mar 5, 2025
Merged

Remove winapi dependency and upgrade windows-sys to 0.59#5581
coolreader18 merged 8 commits into
RustPython:mainfrom
arihant2math:no-winapi

Conversation

@arihant2math

@arihant2math arihant2math commented Mar 3, 2025

Copy link
Copy Markdown
Contributor

close #4078

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! Now we can only have a single windows api source.

Comment thread stdlib/src/socket.rs Outdated
Comment thread stdlib/src/socket.rs Outdated
Comment thread stdlib/src/socket.rs Outdated
Co-authored-by: Jeong, YunWon <69878+youknowone@users.noreply.github.com>
@fanninpm

fanninpm commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

cargo fmt should fix the error.

@arihant2math arihant2math changed the title Remove winapi dependency Remove winapi dependency and upgrade windows-sys to 0.59 Mar 5, 2025
@arihant2math arihant2math requested a review from youknowone March 5, 2025 18:52

@coolreader18 coolreader18 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@coolreader18 coolreader18 merged commit d2bf317 into RustPython:main Mar 5, 2025
@arihant2math arihant2math deleted the no-winapi branch March 5, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch winapi to windows

4 participants