Skip to content

Fix Windows CI - #5168

Merged
youknowone merged 11 commits into
RustPython:mainfrom
derlih:5166-fix-windows-ci
Feb 18, 2024
Merged

Fix Windows CI#5168
youknowone merged 11 commits into
RustPython:mainfrom
derlih:5166-fix-windows-ci

Conversation

@derlih

@derlih derlih commented Feb 16, 2024

Copy link
Copy Markdown
Contributor

Attempt to address #5166

@derlih
derlih force-pushed the 5166-fix-windows-ci branch 2 times, most recently from 65c5780 to 44d7887 Compare February 16, 2024 07:49
@derlih
derlih force-pushed the 5166-fix-windows-ci branch from 44d7887 to 610ec2a Compare February 16, 2024 07:54
@derlih derlih changed the title pin openssl version for windows CI Fix Windows CI Feb 16, 2024
@derlih
derlih force-pushed the 5166-fix-windows-ci branch from 7b77f1a to 0c57fd0 Compare February 17, 2024 10:53
@derlih
derlih force-pushed the 5166-fix-windows-ci branch from 1ed8a01 to 60c1c4e Compare February 17, 2024 11:28
@youknowone

youknowone commented Feb 17, 2024

Copy link
Copy Markdown
Member

Thank you so much! miri failing doesn't look like related.

@derlih

derlih commented Feb 17, 2024

Copy link
Copy Markdown
Contributor Author

Let me polish it a bit. =)

@derlih
derlih force-pushed the 5166-fix-windows-ci branch from 55d09db to f8d531e Compare February 17, 2024 15:08
@derlih

derlih commented Feb 17, 2024

Copy link
Copy Markdown
Contributor Author

@youknowone can you clean up the build cache from this job?
It doesn't contain SSL build and cargo-vcpkg, but I can't invalidate it in an easy way.

@youknowone

Copy link
Copy Markdown
Member

Triggered running again after deleting cache

@youknowone

Copy link
Copy Markdown
Member

The result looks fine

@derlih

derlih commented Feb 18, 2024

Copy link
Copy Markdown
Contributor Author

But not perfect =)
It uses cached cargo-vcpkg but still compiles OpenSSL from sources.
It takes extra 5 minutes of the Windows build. I though vcpkg will use cached OpenSSL build.

@derlih
derlih marked this pull request as ready for review February 18, 2024 16:37

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much. Working CI is always better than broken one, so let's merge it first.

How about additonally adding vcpkg directory to actions/cache? would it fix it?

@youknowone
youknowone merged commit 97a0705 into RustPython:main Feb 18, 2024
@derlih
derlih deleted the 5166-fix-windows-ci branch February 19, 2024 07:35
@derlih

derlih commented Feb 19, 2024

Copy link
Copy Markdown
Contributor Author

The problem is that cargo-vcpkg, vcpkg itself and OpenSSL build are cached by rust-cache action. But I guess after the cache restoration the timestamps from files don't match and that's why it needs to build OpenSSL on each build.

@youknowone

Copy link
Copy Markdown
Member

Thank you for explanation

@youknowone youknowone mentioned this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants