Skip to content

Fake PEP-0695 with empty __type_params__ #5098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 1 commit into from
Oct 23, 2023
Merged

Fake PEP-0695 with empty __type_params__ #5098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions vm/src/builtins/function.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ pub struct PyFunction {
defaults_and_kwdefaults: PyMutex<(Option<PyTupleRef>, Option<PyDictRef>)>,
name: PyMutex<PyStrRef>,
qualname: PyMutex<PyStrRef>,
type_params: PyMutex<PyTupleRef>,
#[cfg(feature = "jit")]
jitted_code: OnceCell<CompiledCode>,
}
Expand All @@ -54,7 +55,8 @@ impl PyFunction {
closure: Option<PyTupleTyped<PyCellRef>>,
defaults: Option<PyTupleRef>,
kw_only_defaults: Option<PyDictRef>,
qualname: PyMutex<PyStrRef>,
qualname: PyStrRef,
type_params: PyTupleRef,
) -> Self {
let name = PyMutex::new(code.obj_name.to_owned());
PyFunction {
Expand All @@ -63,7 +65,8 @@ impl PyFunction {
closure,
defaults_and_kwdefaults: PyMutex::new((defaults, kw_only_defaults)),
name,
qualname,
qualname: PyMutex::new(qualname),
type_params: PyMutex::new(type_params),
#[cfg(feature = "jit")]
jitted_code: OnceCell::new(),
}
Expand Down Expand Up @@ -428,6 +431,30 @@ impl PyFunction {
Ok(())
}

#[pygetset(magic)]
fn type_params(&self) -> PyTupleRef {
self.type_params.lock().clone()
}

#[pygetset(magic, setter)]
fn set_type_params(
&self,
value: PySetterValue<PyTupleRef>,
vm: &VirtualMachine,
) -> PyResult<()> {
match value {
PySetterValue::Assign(value) => {
*self.type_params.lock() = value;
}
PySetterValue::Delete => {
return Err(
vm.new_type_error("__type_params__ must be set to a tuple object".to_string())
);
}
}
Ok(())
}

#[cfg(feature = "jit")]
#[pymethod(magic)]
fn jit(zelf: PyRef<Self>, vm: &VirtualMachine) -> PyResult<()> {
Expand Down
3 changes: 2 additions & 1 deletion vm/src/frame.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1642,7 +1642,8 @@ impl ExecutingFrame<'_> {
closure,
defaults,
kw_only_defaults,
PyMutex::new(qualified_name.clone()),
qualified_name.clone(),
vm.ctx.empty_tuple.clone(), // FIXME: fake implementation
)
.into_pyobject(vm);

Expand Down