Skip to content

fix type_check#5097

Merged
youknowone merged 1 commit into
RustPython:mainfrom
dannasman:type_check_fix
Oct 20, 2023
Merged

fix type_check#5097
youknowone merged 1 commit into
RustPython:mainfrom
dannasman:type_check_fix

Conversation

@dannasman

@dannasman dannasman commented Oct 19, 2023

Copy link
Copy Markdown
Contributor

Hi!

I noticed that there was an error in my earlier pull request (#5091 ). fast_isinstance() should be called by self instead of self.class() in type_check. Sorry for the inconvenience.

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youknowone youknowone merged commit 0357661 into RustPython:main Oct 20, 2023
@dannasman dannasman deleted the type_check_fix branch October 20, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants