Add type_check to _check()#5095
Conversation
|
Welcome to the common RustPython development rabbit hole. Well, I only have general debug advices. It can be either a bug here or combination of other incompatabilty issues there - because getset is shown in error message, I suspect our incomplete getset_descriptor implementation may be releated. I think the trial was really good. I am currently on vacation. I can try a quick look, but not able to look deep down stuff for a while. (To be honest, usually not very helpful for these kind of problems even if I do that) |
|
Alright, I'll keep digging deeper. Have a nice vacation! |
|
@dannasman Do you have a specific goal to achieve? Otherwise looking around similar issues may be helpful. I also have many abandoned patches when I got stucked https://github.com/RustPython/RustPython/pulls/youknowone |
|
I was searching for places where PyObject_TypeCheck should be used in the code and found the |
4be9f81 to
ded6be5
Compare
Hi!
After implementing
type_check(#5091) I tried to add thetype_checkcall in_checkfunction by following the CPython implementation. I also modifieddescr_getfunction ofPyGetSetbased on its CPython counterpart. These modifications cause the code to panic and I am not quite sure why. Any thoughts?