Skip to content

Add missing 'sysinfoapi' feature for winapi#5094

Merged
youknowone merged 3 commits into
RustPython:mainfrom
zaddach:fix_winapi_deps
Oct 20, 2023
Merged

Add missing 'sysinfoapi' feature for winapi#5094
youknowone merged 3 commits into
RustPython:mainfrom
zaddach:fix_winapi_deps

Conversation

@zaddach

@zaddach zaddach commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

stdlib doesn't compile on Windows MSVC x64 otherwise.

@zaddach zaddach changed the title Add missing 'sysinfoapi' dependency for winapi Add missing 'sysinfoapi' feature for winapi Oct 17, 2023
@fanninpm

Copy link
Copy Markdown
Contributor

I believe we're in the process of transitioning away from the winapi crate towards the windows crate.

cc @youknowone

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zaddach you seem to set git email wrong or at least not same as your github account. Could you check it?

@fanninpm Yes, but I think that's not related to this issue. If we are not going to do it right now, we will want to fix build bug.

@zaddach

zaddach commented Oct 18, 2023

Copy link
Copy Markdown
Contributor Author

@youknowone I've updated the email address in the commits to the one on Github.

@youknowone youknowone merged commit d32cb7e into RustPython:main Oct 20, 2023
@youknowone

Copy link
Copy Markdown
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants