Skip to content

rename os module's exit function to _exit as thats how it is defined in cpython #4887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 8 commits into from
Apr 21, 2023
Merged

rename os module's exit function to _exit as thats how it is defined in cpython #4887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
68302c2
rename os exit to _exit as thats how it is defined in cpython
Apr 18, 2023
9764f83
rename os module's exit function to _exit as thats how it is defined …
itsankitkp Apr 18, 2023
0fa4609
Merge branch 'rename-os-exit-function' of github.com:itsankitkp/RustP…
itsankitkp Apr 18, 2023
f703faa
Merge branch 'main' of github.com:itsankitkp/RustPython into rename-o…
itsankitkp Apr 19, 2023
59ac16a
chore! add skip tag for unimplemented feature
itsankitkp Apr 20, 2023
17f8961
Update Lib/test/test_importlib/test_threaded_import.py
itsankitkp Apr 20, 2023
048bd3c
Merge branch 'main' of github.com:itsankitkp/RustPython into rename-o…
itsankitkp Apr 20, 2023
4eadcae
Merge branch 'rename-os-exit-function' of github.com:itsankitkp/RustP…
itsankitkp Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/test/test_importlib/test_threaded_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
# randrange, and then Python hangs.

import _imp as imp
import _multiprocessing # TODO: RUSTPYTHON
import os
import importlib
import sys
Expand Down Expand Up @@ -260,6 +261,7 @@ def test_concurrent_futures_circular_import(self):
'partial', 'cfimport.py')
script_helper.assert_python_ok(fn)

@unittest.skipUnless(hasattr(_multiprocessing, "SemLock"), "TODO: RUSTPYTHON, pool_in_threads.py needs _multiprocessing.SemLock")
@unittest.expectedFailureIfWindows("TODO: RUSTPYTHON")
def test_multiprocessing_pool_circular_import(self):
# Regression test for bpo-41567
Expand Down
2 changes: 1 addition & 1 deletion vm/src/stdlib/os.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1167,7 +1167,7 @@ pub(super) mod _os {
}

#[pyfunction]
fn exit(code: i32) {
fn _exit(code: i32) {
std::process::exit(code)
}

Expand Down