rename os module's exit function to _exit as thats how it is defined in cpython#4887
Conversation
|
Your profile picture is not showing up next to the commit. Did you set up your git email correctly? |
…ython into rename-os-exit-function
It was apprently not setup up properly. Git used to throw error when I didn't set it properly but not sure why it doesn't do that now. |
I usually use some sort of |
That would have been better, now I have three commits just for adding |
Look at the bottom of your other pull request (about |
Okay got it, thanks for head up. |
|
In |
|
how is this happening? looking so irrelevent. |
|
on this branch, if I run script directly On main branch I get this (long traceback warning) on cpython it runs fine Also import multiprocessing
multiprocessing.Pool(1)works fine on cpython, but it doesn't work in rustpython raising error Bottom line: |
|
The CI failures on Windows seem to be unrelated. |
Co-authored-by: fanninpm <fanninpm@miamioh.edu>
|
Nice catch, thank you! |
…ython into rename-os-exit-function
|
Is there anything pending for this PR? |
youknowone
left a comment
There was a problem hiding this comment.
I am sorry. I was going to investigate if the windows failure is related to this changes - but forgot about the PR after stuck by that.
Thank you!
Thanks |
Cpython's
osmodule doesn't haveexitfunction, instead it is defined as_exit.In rustpython, opposite is the case. This PR aims to fix this discrepancy and rename os.exit to os._exit
Note: noticed during developement of 4877
as forked processes are called to kill themself using os._exit() but that used to fail and process didn't die out.