Skip to content

Fix test_bool test_subclass #4715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
minhrongcon2000 wants to merge 2 commits into from
Closed

Fix test_bool test_subclass #4715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ede5fd
Fix test_bool test_subclass
minhrongcon2000 Mar 18, 2023
20f4fb2
fix lint
youknowone Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Lib/test/test_bool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@
import os

class BoolTest(unittest.TestCase):

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_subclass(self):
try:
class C(bool):
Expand Down
7 changes: 6 additions & 1 deletion vm/src/builtins/int.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use super::{float, PyByteArray, PyBytes, PyStr, PyType, PyTypeRef};
use super::{float, PyBool, PyByteArray, PyBytes, PyStr, PyType, PyTypeRef};
use crate::{
builtins::PyStrRef,
bytesinner::PyBytesInner,
Expand Down Expand Up @@ -213,6 +213,11 @@ impl Constructor for PyInt {
type Args = IntOptions;

fn py_new(cls: PyTypeRef, options: Self::Args, vm: &VirtualMachine) -> PyResult {
if cls.is(PyBool::class(vm)) {
return Err(
vm.new_type_error("int.__new__(bool) is not safe, use bool.__new__()".to_owned())
);
}
let value = if let OptionalArg::Present(val) = options.val_options {
if let OptionalArg::Present(base) = options.base {
let base = base
Expand Down