Update test/test_with.py from CPython 3.11.2#4648
Merged
youknowone merged 2 commits intoRustPython:mainfrom Mar 7, 2023
dalinaum:test_with
Merged
Update test/test_with.py from CPython 3.11.2#4648youknowone merged 2 commits intoRustPython:mainfrom dalinaum:test_with
youknowone merged 2 commits intoRustPython:mainfrom
dalinaum:test_with
Conversation
A TypeError is raised instead of an AttributeError in "with" and "async with" statements for objects which do not support the context manager or asynchronous context manager protocols correspondingly. See also: python/cpython#26809
fanninpm
approved these changes
Mar 6, 2023
Contributor
fanninpm
left a comment
fanninpm
left a comment
There was a problem hiding this comment.
LGTM.
@youknowone we should probably follow up on this change in error type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4564
Tests related to python/cpython#26809 have been marked as failing tests.