Refactor with AsNumber::number_downcast_exact#4637
Merged
Conversation
youknowone
requested review from
DimitrisJim,
fanninpm and
qingshi163
and removed request for
fanninpm
DimitrisJim
reviewed
Mar 7, 2023
| and: atomic_func!(|num, other, vm| PyInt::number_op(num, other, |a, b, _vm| a & b, vm)), | ||
| xor: atomic_func!(|num, other, vm| PyInt::number_op(num, other, |a, b, _vm| a ^ b, vm)), | ||
| or: atomic_func!(|num, other, vm| PyInt::number_op(num, other, |a, b, _vm| a | b, vm)), | ||
| int: atomic_func!(|num, other| Ok(PyInt::number_downcast_exact(num, other))), |
DimitrisJim
approved these changes
Mar 7, 2023
DimitrisJim
left a comment
DimitrisJim
left a comment
Member
There was a problem hiding this comment.
looks good to me, does it need to be rebased first?
youknowone
force-pushed
the
refactor-asnumber
branch
from
4ad3027 to
823b528
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is including #4636