Fix ensurepip install issues #4598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
p.s we should probably remove |
Member
|
Thanks, regression from a6e44a3 |
Member
|
|
youknowone
approved these changes
Feb 28, 2023
Member
Author
|
I really don't know if there's a need for it either. Currently it also pulls down the newest version of pip which we can't run due to some |
DimitrisJim
force-pushed
the
fix_ensurepip
branch
from
4202a57 to
c8d34fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4589 (which most likely applied for all OS's). At some point it seems this change was removed from sysconfig by accident, this adds it back and also adds a check to the CI to make sure its caught in the future.
edit: Removed in #4569 which I also approved 😄