Skip to content

Remove unnecessary to_vec() in bytes.rs #4518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowone merged 1 commit into from
Feb 17, 2023
Merged

Remove unnecessary to_vec() in bytes.rs #4518

youknowone merged 1 commit into from
Feb 17, 2023

Conversation

@dannasman
Copy link
Contributor

@dannasman dannasman commented Feb 17, 2023

One unnecessary to_vec() was not removed in #4500.

fanninpm
fanninpm approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@fanninpm fanninpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@youknowone youknowone merged commit c037e17 into RustPython:main Feb 17, 2023
@dannasman dannasman deleted the unnecessary_tovec branch February 18, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fanninpm fanninpm fanninpm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dannasman @fanninpm @youknowone