Use entire range for generators-as-arguments #4488

charliermarsh · 2023-02-10T15:41:19Z

Given the following:

" ".join(
    sql
    for sql in (
        "LIMIT %d" % limit if limit else None,
        ("OFFSET %d" % offset) if offset else None,
    )
)

The GeneratorExp was using the range of the sql token on the second line, as opposed to the entire range of the actual generator.

charliermarsh · 2023-02-10T20:21:29Z

compiler/parser/src/parser.rs

+)"#;
+        let parse_ast = parse_expression(source, "<test>").unwrap();
+        insta::assert_debug_snapshot!(parse_ast);
+    }


Thank you, I was lazy 🤦

charliermarsh and others added 2 commits February 10, 2023 10:39

Use entire range for generators-as-arguments

65a62b8

Add test_generator_expression_argument

d4207e2

youknowone force-pushed the charlie/gen-exp-arg branch from 3520aeb to d4207e2 Compare February 10, 2023 20:20

charliermarsh commented Feb 10, 2023

View reviewed changes

youknowone approved these changes Feb 10, 2023

View reviewed changes

youknowone merged commit 61b48f1 into RustPython:main Feb 10, 2023

charliermarsh deleted the charlie/gen-exp-arg branch February 10, 2023 21:16

Provide feedback