Repository navigation
Fix docs.rs build for rustpython-parser - #4437
Merged
Merged
Conversation
docs.rs failed to build the documentation of the recently released rustpython-parser 0.2.0 because the build.rs script couldn't write the parser.rs file because docs.rs builds the documentation in a sandbox with a read-only filesystem. This commit fixes this by writing the parser.rs file to the cargo output directory instead, as recommended by the docs.rs documentation.[1] Fixes RustPython#4436. [1]: https://docs.rs/about/builds#read-only-directories
youknowone
approved these changes
Jan 12, 2023
| // We are not using lalrpop::process_root() or Configuration::process_current_dir() | ||
| // because of https://github.com/lalrpop/lalrpop/issues/699. | ||
| lalrpop::Configuration::new() | ||
| .use_cargo_dir_conventions() |
Member
There was a problem hiding this comment.
oh, this is the way to do things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs.rs failed to build the documentation of the recently released rustpython-parser 0.2.0 because the build.rs script couldn't write the parser.rs file because docs.rs builds the documentation in a sandbox with a read-only filesystem.
This commit fixes this by writing the parser.rs file to the cargo output directory instead, as recommended by the docs.rs documentation.1
Fixes #4436.