Improved the fix for the continuing problem in the shell#4406
Merged
youknowone merged 5 commits intoRustPython:mainfrom Jan 5, 2023
Merged
Improved the fix for the continuing problem in the shell#4406youknowone merged 5 commits intoRustPython:mainfrom
youknowone merged 5 commits intoRustPython:mainfrom
Conversation
Member
|
could you please rebase the commits to remove the merge commit? when |
branai
force-pushed
the
shell-continuing-fix
branch
from
850c6f8 to
a2881d1
Compare
Contributor
Author
|
I added two small changes here to @DimitrisJim I'd like to fix |
youknowone
approved these changes
Jan 4, 2023
Member
youknowone
left a comment
youknowone
left a comment
There was a problem hiding this comment.
looks good. please check the use statement part glitch.
src/shell.rs
Outdated
| AsObject, PyResult, VirtualMachine, | ||
| }; | ||
|
|
||
| use rustpython_parser::token::Tok; |
Member
There was a problem hiding this comment.
This line can be a part of line 3.
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved my fix for #3892