Skip to content

Add BOM check - #4359

Merged
youknowone merged 3 commits into
RustPython:mainfrom
yt2b:check_bom
Dec 26, 2022
Merged

youknowone merged 3 commits into
RustPython:mainfrom
yt2b:check_bom

Conversation

@yt2b

@yt2b yt2b commented Dec 25, 2022 •

Copy link
Copy Markdown
Contributor

#4353
I've added BOM check in Lexer.

With this fix, the following tests now pass.
So I've removed the decorators.

  • test_bom
  • test_bom_and_utf_8

Comment thread compiler/parser/src/lexer.rs Resolved

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for now, thank you

@youknowone
youknowone merged commit 247e815 into RustPython:main Dec 26, 2022
@yt2b
yt2b deleted the check_bom branch December 26, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants