Add complex.{__abs__, __eq__, __neg__} #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OddCoincidence
force-pushed
the
complex
branch
from
17fc07b to
520f71f
Compare
Collaborator
|
Can we test these using idiomatic python rather than calling the magic methods directly: Eg: etc? |
Contributor
|
@cthulahoops I agree, this is cleaner testcode. It will invoke the magic method at some point in time. |
| pub map_type: PyObjectRef, | ||
| pub memoryview_type: PyObjectRef, | ||
| pub none: PyObjectRef, | ||
| pub not_implemented: PyObjectRef, |
Contributor
There was a problem hiding this comment.
Wow, I cannot be believe we did not implement this yet ;)
OddCoincidence
changed the title
This was referenced Feb 9, 2019
Contributor
Author
|
Thanks to @cthulahoops's suggestion, I think I found a subtle bug in the way the binary magic methods currently are implemented. Filed as #419. I will work around it here, and fix this in another PR. |
Collaborator
|
Looks ready to merge, but has conflicts to resolve. |
Contributor
|
I resolved the conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former required the addition of the
NotImplementedconstant to match cpython`s behavior.