Repository navigation
generated parser cache out of repository - #4090
Conversation
c1523be to
770df07
Compare
|
It might make more sense to undo #3652. |
|
@coolreader18 didn't want to add lalrpop dependency for main CI path. I'd like to find a way to meet the requirement. |
|
@fanninpm you know both the previous work and this change. you had a coverage concern. I want to know how you think about removing it again. @coolreader18 I tried best to meet your requirements. please check if I missed something when you come back later. |
I welcome this sort of change because I think it should ease the burden placed upon new/novice contributors. (See, for example, #3879 (comment).) I'm not too concerned about test coverage for the code that LALRPOP generates, especially because I don't see a clear way to represent test coverage of a LALRPOP source file. |
|
Thank you, lets try |
|
For this, wouldn't someone need to always either have |
|
Oh, welcome back. Yes. it will require lalrpop for first build. About the lalrpop running time, not the build time, it was already reasonable fast on my machines when #3652 made. So it is hard to be able to tell about it. I don't think the running time is enhanced much. |
|
This change probably broke the docs.rs build for rustpython-parser, see #4436. But I am afraid I understand too little of the build system to know how we can resolve this. |
No description provided.