Repository navigation
Conversation
key262yek
force-pushed
the
update-invalid_argument
branch
3 times, most recently
from
July 21, 2022 08:44
4768997 to
e174d2d
Compare
key262yek
changed the title
key262yek
force-pushed
the
update-invalid_argument
branch
from
July 27, 2022 07:23
f89b428 to
aa1a946
Compare
key262yek
force-pushed
the
update-invalid_argument
branch
from
September 21, 2022 12:21
aa1a946 to
9207c7a
Compare
Member
|
I don't know how easy the conflicts are going to be to resolve (some recent prs to the grammar and the parser cover some of these changes). The parenthesized genexprs aren't as far as I can tell (the test in main is still marked as failing) so there's still something to be solved here. |
Member
|
Should be moved to Parser, |
Member
|
Thank you for working on this, @key262yek! This issue has since been fixed in the current codebase — unparenthesized generator expressions now correctly raise SyntaxError. Closing as resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix RustPython/Parser#84