Skip to content

Implement missing methods to MappingProxy#3898

Merged
youknowone merged 4 commits into
RustPython:mainfrom
jopemachine:add-missing-method-mapping-proxy
Jul 18, 2022
Merged

Implement missing methods to MappingProxy#3898
youknowone merged 4 commits into
RustPython:mainfrom
jopemachine:add-missing-method-mapping-proxy

Conversation

@jopemachine

@jopemachine jopemachine commented Jul 16, 2022

Copy link
Copy Markdown
Contributor

Fixes #3875.

@jopemachine jopemachine force-pushed the add-missing-method-mapping-proxy branch from d8f7241 to ad27a0f Compare July 16, 2022 04:14
@youknowone youknowone added the z-ca-2022 Tag to track contrubution-academy 2022 label Jul 16, 2022
Snowapril
Snowapril reviewed Jul 16, 2022
View reviewed changes
Comment thread vm/src/builtins/mappingproxy.rs Outdated
@Snowapril

Snowapril commented Jul 16, 2022

Copy link
Copy Markdown
Contributor

As you implement __or__ and __ior__ for mapping proxy, You can also implement number protocol for mappingproxy just by connecting the fields. The only fields that mappingproxy providing for number protocol are __or__ and __ior__. You can do that in this PR or seaprate PR

Snowapril
Snowapril reviewed Jul 16, 2022
View reviewed changes
Comment thread Lib/test/test_types.py Outdated
Snowapril
Snowapril reviewed Jul 16, 2022
View reviewed changes
Comment thread vm/src/builtins/mappingproxy.rs Outdated
Snowapril
Snowapril reviewed Jul 16, 2022
View reviewed changes
Comment thread vm/src/builtins/mappingproxy.rs Outdated
Snowapril
Snowapril reviewed Jul 16, 2022
View reviewed changes
Comment thread vm/src/builtins/mappingproxy.rs Outdated
@youknowone youknowone requested a review from qingshi163 July 16, 2022 13:44
@youknowone

youknowone commented Jul 17, 2022

Copy link
Copy Markdown
Member

https://github.com/RustPython/RustPython/pull/3910/files#diff-a040eea55332ac71f2f5db3966f7261f844ceceaac675cc0f30eb973d2593a26R108-R109

qingshi163
qingshi163 approved these changes Jul 18, 2022
View reviewed changes

@qingshi163 qingshi163 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!

@youknowone youknowone merged commit 715dac9 into RustPython:main Jul 18, 2022
This was referenced Jul 18, 2022
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

@qingshi163 qingshi163 qingshi163 approved these changes

+1 more reviewer

@Snowapril Snowapril Snowapril left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

z-ca-2022 Tag to track contrubution-academy 2022

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement missing methods to MappingProxy

4 participants

@jopemachine @Snowapril @youknowone @qingshi163