Repository navigation
Update exception tests from CPython v3.10.5 - #3873
Merged
Merged
Conversation
fanninpm
reviewed
Jul 13, 2022
fanninpm
left a comment
fanninpm
left a comment
Contributor
There was a problem hiding this comment.
Just a couple of little nitpicks regarding code attribution.
key262yek
force-pushed
the
update-exceptions-test
branch
from
July 13, 2022 20:50
5ff3c5a to
4400493
Compare
fanninpm
approved these changes
Jul 14, 2022
fanninpm
left a comment
fanninpm
left a comment
Contributor
There was a problem hiding this comment.
Tests now look good. @youknowone are there any other outstanding concerns before merging this?
Member
|
nope, it looks perfect to me. Thank you for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
Lib/test/test_exceptions.py
Lib/test/test_cmd_line_script.py
Lib/test/test_syntax.py