Skip to content

use static reference for AsMapping / AsSequence#3750

Merged
youknowone merged 9 commits into
RustPython:mainfrom
youknowone:as-mapping-const
May 29, 2022
Merged

use static reference for AsMapping / AsSequence#3750
youknowone merged 9 commits into
RustPython:mainfrom
youknowone:as-mapping-const

Conversation

@youknowone

@youknowone youknowone commented May 27, 2022

Copy link
Copy Markdown
Member

3% from pystone

3.5% from fannkuch

+-----------+-----------------+------------------------+------------------------+
| Benchmark | rustpython_orig | mapping                | mapping+sequence        |
+===========+=================+========================+========================+
| fannkuch  | 3.79 sec        | 3.67 sec: 1.03x faster | 3.65 sec: 1.04x faster |
+-----------+-----------------+------------------------+------------------------+
+-----------+---------+-------------------------+
| Benchmark | cpython | rustpython-final        |
+===========+=========+=========================+
| fannkuch  | 354 ms  | 3.64 sec: 10.26x slower |
+-----------+---------+-------------------------+

@youknowone youknowone requested a review from qingshi163 May 28, 2022 06:04
@youknowone youknowone force-pushed the as-mapping-const branch 2 times, most recently from 44831bb to b4b18c9 Compare May 28, 2022 17:24
@youknowone

Copy link
Copy Markdown
Member Author

@Snowapril would you review this PR?

@youknowone youknowone changed the title simplify AsMapping simplify AsMapping / AsSequence May 28, 2022
@youknowone youknowone changed the title simplify AsMapping / AsSequence use static reference for AsMapping / AsSequence May 28, 2022

@Snowapril Snowapril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems better to use static ref than before 😊

@youknowone youknowone merged commit 8e20e23 into RustPython:main May 29, 2022
@youknowone youknowone deleted the as-mapping-const branch May 29, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants