Skip to content

Add count.reduce()#3737

Merged
youknowone merged 4 commits into
mainfrom
unknown repository
May 22, 2022
Merged

Add count.reduce()#3737
youknowone merged 4 commits into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented May 22, 2022

Copy link
Copy Markdown

ref #3611

@youknowone

Copy link
Copy Markdown
Member

are there related tests in test_itertools.py?

@fanninpm

Copy link
Copy Markdown
Contributor

are there related tests in test_itertools.py?

test_count() has a pickle-related section.

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not compatible to pickle

Comment thread vm/src/stdlib/itertools.rs Outdated
Ok(*times.read())
}


Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Comment thread vm/src/stdlib/itertools.rs Outdated
#[pyimpl(with(IterNext, Constructor))]
impl PyItertoolsCount {}
impl PyItertoolsCount {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for contributing!

@youknowone youknowone merged commit a019cbf into RustPython:main May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants