Fixed test_bytearray_translate Error#3730
Merged
Merged
Conversation
FileName: test_builtin.py FunctionName: test_bytearray_translate Error: RustPython was throwing wrong Error, RustPython was throwing TypeError Signed-off-by: Lithium07z <Lithium@hallym.ac.kr>
youknowone
requested changes
May 21, 2022
| || Ok((0..=255).collect::<Vec<u8>>()), | ||
| |v| { | ||
| |v: PyObjectRef| { | ||
| let v: PyBytesInner = v.try_into_value(vm).map_err(|_| { |
Member
There was a problem hiding this comment.
The error handling part can be shared
let bytes = v
.try_into_value::<PyBytesInner>(vm)
.ok()
.filter(|v| v.elements.len() == 256)
.ok_or_else(|| {
vm.new_value_error(
"translation table must be 256 characters long".to_owned(),
)
})?;
Ok(bytes.elements.to_vec())FileName: bytesinner.rs Reason: The error handling part can be shared, so merged it two of error handling parts
youknowone
approved these changes
May 22, 2022
youknowone
left a comment
youknowone
left a comment
Member
There was a problem hiding this comment.
thank you for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileName:
test_builtin.pyFunctionName:
test_bytearray_translateError: RustPython was throwing wrong
Error, RustPython was throwingTypeError