Add object.__sizeof__#3728
Merged
Merged
Conversation
youknowone
approved these changes
May 21, 2022
Member
|
thank you! it looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a look at
object.__sizeof__. @moreal opened a pull request (#3421) on it last year, but it never got finished.CPython uses
tp_basicsize,tp_itemsize, andob_sizein__sizeof__. The intended use oftp_basicsizeandtp_itemsizecan be seen, e.g., at https://docs.python.org/3/extending/newtypes_tutorial.html#defining-new-types. Since new types are implemented different in RustPython we don't needtp_itemsize(andob_size).If merged, this should be the last point for #2898.
Can you give me some feedback? Thanks!