Skip to content

Update dependencies for the demo#3679

Closed
jtpio wants to merge 4 commits into
RustPython:mainfrom
jtpio:update-demo
Closed

Update dependencies for the demo#3679
jtpio wants to merge 4 commits into
RustPython:mainfrom
jtpio:update-demo

Conversation

@jtpio

@jtpio jtpio commented May 2, 2022

Copy link
Copy Markdown

This PR updates the dependencies used for the Wasm demo:

  • Update to webpack 5
  • Add package-lock.json to keep track of the current set of dependencies
  • Switch to the asset modules (added in webpack 5)

The motivation was to get the demo to work locally, before trying to update the demo page following the instructions in: https://github.com/RustPython/RustPython/blob/main/wasm/README.md#updating-the-demo

Comment thread wasm/demo/webpack.config.js Outdated
Comment thread wasm/demo/webpack.config.js Outdated
@jtpio

jtpio commented May 8, 2022

Copy link
Copy Markdown
Author

There still seems to be an issue when switching between code samples.

Will try to get back to it some time this week.

@DimitrisJim

Copy link
Copy Markdown
Member

I reckon we still need this but it probably isn't as straight-forward as it looked?

jtpio and others added 4 commits February 23, 2023 11:02
Co-authored-by: fanninpm <fanninpm@miamioh.edu>
Co-authored-by: fanninpm <fanninpm@miamioh.edu>
@jtpio

jtpio commented Feb 23, 2023

Copy link
Copy Markdown
Author

I just rebased this PR onto the latest main to trigger CI, since the logs for the original run are not available anymore.

@arihant2math

Copy link
Copy Markdown
Contributor

These have now been updated with #5585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants