Skip to content

implement aiter #3646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Apr 22, 2022
Merged

implement aiter #3646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8455c74
implement aiter
sum12 Apr 19, 2022
d74a1d5
added test for builtin.aiter
sum12 Apr 19, 2022
5fdf62a
Check for PyAsyncGen when calling aiter
sum12 Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Lib/test/test_asyncgen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,8 +543,6 @@ async def consume():
self.loop.run_until_complete(consume())
self.assertEqual(results, [1, 2])

# TODO: RUSTPYTHON, NameError: name 'aiter' is not defined
@unittest.expectedFailure
def test_aiter_idempotent(self):
async def gen():
yield 1
Expand Down Expand Up @@ -766,8 +764,6 @@ def run_test(test):
run_test(test5)
run_test(test6)

# TODO: RUSTPYTHON, NameError: name 'aiter' is not defined
@unittest.expectedFailure
def test_aiter_bad_args(self):
async def gen():
yield 1
Expand Down
10 changes: 10 additions & 0 deletions vm/src/stdlib/builtins.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ mod builtins {
use crate::compile;
use crate::{
builtins::{
asyncgenerator::PyAsyncGen,
enumerate::PyReverseSequenceIterator,
function::{PyCellRef, PyFunctionRef},
int::PyIntRef,
Expand Down Expand Up @@ -426,6 +427,15 @@ mod builtins {
}
}

#[pyfunction]
fn aiter(iter_target: PyObjectRef, vm: &VirtualMachine) -> PyResult {
if iter_target.payload_is::<PyAsyncGen>() {
vm.call_special_method(iter_target, "__aiter__", ())
} else {
Err(vm.new_type_error("wrong argument type".to_owned()))
}
}

#[pyfunction]
fn len(obj: PyObjectRef, vm: &VirtualMachine) -> PyResult<usize> {
obj.length(vm)
Expand Down