implement aiter #3646
implement aiter #3646
Conversation
|
Will you add a simple test if it actually calls |
I think we can just update our copy of |
|
I think you already added tests from the CPython, but here is a guideline if you want to know the regular way: https://github.com/RustPython/RustPython/wiki/How-to-update-test-files |
youknowone
left a comment
youknowone
left a comment
There was a problem hiding this comment.
looks good for codes. I have one more request for the commit message. For the commit for test update (64cb090), please leave the updated source of the CPython version. That will be very useful for future contributor of the file. Because git log Lib/test/test_asyncgen.py will show how it is changed by the history just by looking for the log.
|
Because #3647 updated the test file, rebase will be enough |
the caller is expected to make sure that the passed in object does in fact supports the protocol relates RustPython#3609
|
@sum12 If you want, converting it to use slots would be also an approachable task |
3 participants
the caller is expected to make sure that the passed in object does in
fact supports the protocol
relates #3609