Skip to content

Rename PyObjectView -> Py and PyValue -> PyPayload - #3630

Merged
youknowone merged 6 commits into
RustPython:mainfrom
youknowone:rename-pyobjectview
Apr 22, 2022
Merged

youknowone merged 6 commits into
RustPython:mainfrom
youknowone:rename-pyobjectview

Conversation

@youknowone

@youknowone youknowone commented Apr 17, 2022 •

Copy link
Copy Markdown
Member

As I remember, the name Py was @coolreader18's idea, right?

After reviewing their relationships, I agree this is a consistent and not confusing name than now, by showing their relationships in the name.

closes #3631

@youknowone
youknowone requested a review from coolreader18 April 17, 2022 18:47
@youknowone
youknowone force-pushed the rename-pyobjectview branch from 744446c to acfa401 Compare April 17, 2022 19:08
@youknowone youknowone changed the title Rename PyObjectView to Py and remove PyObjectWeak Rename PyObjectView -> Py and PyValue -> PyPayload Apr 17, 2022
@youknowone
youknowone force-pushed the rename-pyobjectview branch from acfa401 to 6586067 Compare April 17, 2022 19:57

@coolreader18 coolreader18 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@youknowone

Copy link
Copy Markdown
Member Author

@coolreader18 what's your idea about PyObjectWeak? Should it be a wrapper of PyRef<PyWeak> or PyRef itself?

@youknowone
youknowone force-pushed the rename-pyobjectview branch from 6586067 to 5a60664 Compare April 22, 2022 20:22
@youknowone
youknowone merged commit c103fe1 into RustPython:main Apr 22, 2022
@youknowone
youknowone deleted the rename-pyobjectview branch April 22, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC] Give proper names to types and traits

2 participants