Align test/support/os_helper with CPython 3.10#3547
Merged
Conversation
deantvv
suggested changes
Feb 11, 2022
deantvv
left a comment
deantvv
left a comment
Contributor
There was a problem hiding this comment.
The PR looks great!
Just one nitpick. If we are trying to align with CPython 3.10, we could also remove copy (L626-628) part since it is only in CPython main branch.
youknowone
approved these changes
Feb 12, 2022
fanninpm
force-pushed
the
test-support-os-helper
branch
from
93ffdf2 to
a7dd8b0
Compare
youknowone
approved these changes
Feb 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requesting @deantvv as a reviewer.