Merged
Conversation
Contributor
Author
|
Now, CI is blocked by |
Member
|
is this happened because |
Contributor
Author
|
I think that it's because |
fanninpm
force-pushed
the
fix-fstring-format-spec
branch
from
b51ae20 to
ef64b21
Compare
fanninpm
force-pushed
the
fix-fstring-format-spec
branch
from
ef64b21 to
a936c36
Compare
Member
|
great, thank you! |
youknowone
approved these changes
Feb 6, 2022
youknowone
approved these changes
Feb 6, 2022
Member
youknowone
left a comment
youknowone
left a comment
There was a problem hiding this comment.
looks good to me, but I am not very familiar with this part. so I want to let a few days for @coolreader18's review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was using CPython 3.9's
Lib/test/test_fstring.pyas an implementation guide to track my progress, but there's still a long way to go, particularly w/r/t escape sequences.Should fix #3531.