Skip to content

Update to Rust 1.58#3518

Closed
fanninpm wants to merge 7 commits into
RustPython:mainfrom
fanninpm:please-make-ci-green
Closed

Update to Rust 1.58#3518
fanninpm wants to merge 7 commits into
RustPython:mainfrom
fanninpm:please-make-ci-green

Conversation

@fanninpm

Copy link
Copy Markdown
Contributor

This (hopefully) should include everything necessary to turn the CI green. Submitting as draft so @coolreader18 can comment on the U̴̬̭̪̺̯̳̭͍̭̫̲̇̌̓̋̀͗̂͑̆͋̆͘̕͘͜͝ͅN̷̡̥̖̺̫̬͇̭̰̑S̷̡̨̯̟̳̻̙̟̪̯̘̋͂̓͌̎̈́̀̎̌̚ͅO̸̧̢̡̹͔͗́̑̍͐̐̏̓̒͂̓͗̃͘͜͜͝͝Ǘ̴͓̳̼̤̺̩̤̤̟̫̹̮͉͑͗̅̔͑̈̒͊̓͜͝Ņ̴͚̣͙̜̖̤̖̫̞͇̰̋̔̏͆̽̀̆̾̀͜͝͝ͅḐ̷̛̛̯̻̠͚̙̬̝̼̳̯̺̬͔̳̰̆͒̒̄̆͆͠͠ͅẼ̸̮̤̎̒̄̔̉̂̑̌̎̅̑͒̄̾͘̕S̷͙͍͚͚͓̜̔̈́͋̾͆́̄͒̕͝͝S̷̨̟̦̭̭̘͋͌͌̐̊́́̓̕̚͝ issues.

@coolreader18

Copy link
Copy Markdown
Member

Oh, ha, I also did the same stuff in #3516. The unsoundness issues should be fine, they're resolvable w/o a #[allow()] except for the one in pyobjectrc which is just a false positive. The only real possible soundness issue is in jit but I think it's just an oversight from cranelift that JITModule isn't Send.

@fanninpm

Copy link
Copy Markdown
Contributor Author

Closing in favor of #3516.

@fanninpm fanninpm closed this Jan 14, 2022
@fanninpm fanninpm deleted the please-make-ci-green branch January 15, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants