Fix doctests in ci#3516
Conversation
coolreader18
commented
Jan 9, 2022
coolreader18
commented
- Fix doc comment for Interpreter
- Fix doctests in ci
| # ugly hack since doctests link against debug version of rustpython-vm even | ||
| # when profile.test is optimized |
There was a problem hiding this comment.
Though we usually use optimization and debug option exclusively, optimization is about optimization itself and debug is about debug information. So I think giving optimization option to test doesn't change whether it is a debug or not.
There was a problem hiding this comment.
Right, and it does work fine unoptimized on our machines apparently, but I think there's some timeout in ci that kills the test process if it takes too long? And afaict it was linking against release in Rust 1.56, the update broke it a bit, this just brings it back to previous behavior
There was a problem hiding this comment.
ach wait the tests aren't even fixed, dang it
There was a problem hiding this comment.
yep, I think it shouldn't fix anything unless it is related to cache
There was a problem hiding this comment.
ugh I don't know why I didn't consider that it was a cache issue
There was a problem hiding this comment.
The cache action is reporting a cache miss, so I doubt that it's actually a cache issue.
coolreader18
force-pushed
the
fix-ci
branch
2 times, most recently
from
59005c4 to
6e340a7
Compare
|
WOOOooooooo....! Passing! |
|
Merging this so main turns green. |
| [profile.test] | ||
| opt-level = 3 | ||
| lto = "thin" | ||
| # https://github.com/rust-lang/rust/issues/92869 |
There was a problem hiding this comment.
this is totally unexpected effect
3 participants
