Update test for support/os_helper.py (second attempt)#3476
Merged
Conversation
This reverts commit 20cef39.
youknowone
approved these changes
Nov 28, 2021
youknowone
left a comment
youknowone
left a comment
Member
There was a problem hiding this comment.
great! I was waiting for this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second attempt to update
test/support/os_helper.py(original #3433)Plan to update all code under Lib/test/support.
This PR only cover the change for Lib/test/support/os_helper.py and reflect the changes necessary for other tests to use.
It is already a big one so I decide to make a PR for this and plan for others (import_helper, socket_helper...) to go for another PR.
Mostly of the part is from test.support import TESTFN --> from test.support.os_helper import TESTFN etc..
Follow up for #3424