Update test for support/os_helper.py#3433
Merged
Merged
Conversation
Contributor
Author
|
The test failure seems not related to this PR and also failed on master CI test. |
youknowone
approved these changes
Nov 15, 2021
youknowone
left a comment
youknowone
left a comment
Member
There was a problem hiding this comment.
Thanks! it looks like a huge work
Member
|
I thought the failing test is only about broken CI on main branch but more windows tests looks failing |
youknowone
added a commit
that referenced
this pull request
Nov 17, 2021
Revert "Merge pull request #3433 from deantvv/test-update"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan to update all code under
Lib/test/support.This PR only cover the change for
Lib/test/support/os_helper.pyand reflect the changes necessary for other tests to use.It is already a big one so I decide to make a PR for this and plan for others (import_helper, socket_helper...) to go for another PR.
Mostly of the part is
from test.support import TESTFN-->from test.support.os_helper import TESTFNetc..Follow up for #3424