Skip to content

os: update test PidTests#3424

Closed
deantvv wants to merge 1 commit into
RustPython:mainfrom
deantvv:test-os-PidTests
Closed

os: update test PidTests#3424
deantvv wants to merge 1 commit into
RustPython:mainfrom
deantvv:test-os-PidTests

Conversation

@deantvv

@deantvv deantvv commented Nov 7, 2021

Copy link
Copy Markdown
Contributor

Follow up test for #3423

@DimitrisJim

Copy link
Copy Markdown
Member

Is this a partial update to the test file?

@deantvv

deantvv commented Nov 7, 2021

Copy link
Copy Markdown
Contributor Author

Is this a partial update to the test file?

Yes. I was thinking about updating the whole file but it would change Lib/test/support/ a lot and inevitably will be quite a large PR. I can do that if you prefer it that way.

This PR add one more passing test to windows but it doesn't add any more passing tests in unix since it requires os.spawnv.

@DimitrisJim

Copy link
Copy Markdown
Member

Yes. I was thinking about updating the whole file but it would change Lib/test/support/ a lot and inevitably will be quite a large PR. I can do that if you prefer it that way.

That's generally preferable, if you're willing to update them! (If its too much of a hassle I'll take a stab at it when I find time for it)

@deantvv

deantvv commented Nov 7, 2021

Copy link
Copy Markdown
Contributor Author

Yes, I can update them. I will try to find some time next week for it.
Closing for now, will open another PR once it is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants