Fix GenericAlias parameter chaining#3394
Merged
Merged
Conversation
Snowapril
force-pushed
the
fix-ga-param-chaining
branch
from
c27691e to
c18febe
Compare
make_parameters must not push duplicated parameters as cpython implementation. See `tuple_add` function of `genericaliasobject.c` in cpython code https://github.com/python/cpython/blob/main/Objects/genericaliasobject.c#L191 Signed-off-by: snowapril <sinjihng@gmail.com>
Signed-off-by: snowapril <sinjihng@gmail.com>
Signed-off-by: snowapril <sinjihng@gmail.com>
As this extra_test already covered by `test_parameter_chaining` in `test_genericalias.py`, remove duplicated test Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril
force-pushed
the
fix-ga-param-chaining
branch
from
c18febe to
f6c2999
Compare
youknowone
approved these changes
Oct 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This revision fix some misworking functions
make_parameters&subs_tvarstest_parametersandtest_parameter_chainingtests now going successI removed
extra_tests/snippets/test_typing.pywhich I added in #3374, that I had been thought there are no tests forusing
TypeVarwithGenericAlias. It is actually covered bytest_parameter_chainingintest_genericalias.py@moreal Could you review this commit? As you originally added this commit, I'd be a pleasure if you review this one 😊
In cpython, only they push parameters if they are not already exist. I fixed that mismatch between rustpython.