Refactor OSError#3391
Merged
Merged
Conversation
deantvv
force-pushed
the
os-error-refactor
branch
from
7f7efb3 to
9e06736
Compare
Member
|
@ChJR could you review this PR? |
Contributor
|
I think this PR makes OSError better before. |
Contributor
|
If this PR can be merged into 'main' branch, it could be helpful for making errno as attribute, required to pass windows test of #2993. |
deantvv
force-pushed
the
os-error-refactor
branch
from
9e06736 to
429a08b
Compare
Implement `raw_os_error_to_exc_type` to reduce duplication of errno to exception type.
deantvv
force-pushed
the
os-error-refactor
branch
from
429a08b to
a59556a
Compare
youknowone
approved these changes
Oct 30, 2021
Member
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
raw_os_error_to_exc_typeto reduce duplication of errno toexception type.