Skip to content

underscore issue on parse_str (fmt done) - #3389

Closed
eunsung-lim wants to merge 6 commits into
RustPython:mainfrom
eunsung-lim:main
Closed

eunsung-lim wants to merge 6 commits into
RustPython:mainfrom
eunsung-lim:main

Conversation

@eunsung-lim

Copy link
Copy Markdown

I sent a pull request #3194 without formatting.
Now, I've done with cargo fmt --all command.
I think I need to do some works on #3194 but cannot find the way how to send a pull request continuously with my previous PR. If you know about it, please let me know...

@youknowone

Copy link
Copy Markdown
Member

Could you please do rebase rather than merge? Also, when you select Files Changed tap, nothing more than your contribution showed up.

@youknowone

Copy link
Copy Markdown
Member

Another thing. You don't need to open a new PR for every revision. git push --force to the original remote branch will replace codes from the original PR.

@youknowone

Copy link
Copy Markdown
Member

looking like outdated.
thank you for the effort!

@youknowone youknowone closed this Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants