Skip to content

Relocate vm.rich_compare to obj.rich_compare#3347

Merged
DimitrisJim merged 1 commit into
RustPython:mainfrom
Limits0x:relocate-rich_compare
Oct 20, 2021
Merged

Relocate vm.rich_compare to obj.rich_compare#3347
DimitrisJim merged 1 commit into
RustPython:mainfrom
Limits0x:relocate-rich_compare

Conversation

@Limits0x

Copy link
Copy Markdown
Contributor

Fixes task 4 of #3324

@Snowapril

Copy link
Copy Markdown
Contributor

You need rebasing. These docs will be helpful.

@Limits0x Limits0x force-pushed the relocate-rich_compare branch from aaaf87e to 7eb600b Compare October 20, 2021 03:23
@Limits0x

Copy link
Copy Markdown
Contributor Author

@Snowapril Is this fine ? Can you review it ?

@Snowapril

Snowapril commented Oct 20, 2021

Copy link
Copy Markdown
Contributor

Uh... It seems something going wrong. first of all, merge commit must not be in the PR.
your branch have _hash but main branch do not have it. this conflict is main cause of blocking.

general rebasing process for resolving conflict is something like this.

  1. git fetch upstream main
  2. git rebase upstream/main (then there will be conflict codes in vm.rs, in this case, you need to remove both of them)
  3. (after solving conflict) git add vm/src/vm.rs
  4. git rebase --continue
  5. git push origin relocate-rich_compare -f

@Snowapril

Copy link
Copy Markdown
Contributor

you also need to drop merge commit (which is top of your branch currently)

@Limits0x Limits0x force-pushed the relocate-rich_compare branch from 5a7ea06 to c427462 Compare October 20, 2021 04:15
@Limits0x

Copy link
Copy Markdown
Contributor Author

@Snowapril I followed the steps you provided and also dropped the merge commit. Is it fine now ?

@Snowapril

Copy link
Copy Markdown
Contributor

Oh! it seems perfect now! Great job 😊

@DimitrisJim DimitrisJim merged commit b7dab09 into RustPython:main Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants