Relocate vm.rich_compare to obj.rich_compare#3347
Merged
Merged
Conversation
10 tasks
Contributor
|
You need rebasing. These docs will be helpful. |
aaaf87e to
7eb600b
Compare
Contributor
Author
|
@Snowapril Is this fine ? Can you review it ? |
Contributor
|
Uh... It seems something going wrong. first of all, merge commit must not be in the PR. general rebasing process for resolving conflict is something like this.
|
Contributor
|
you also need to drop merge commit (which is top of your branch currently) |
5a7ea06 to
c427462
Compare
Contributor
Author
|
@Snowapril I followed the steps you provided and also dropped the merge commit. Is it fine now ? |
Contributor
|
Oh! it seems perfect now! Great job 😊 |
DimitrisJim
approved these changes
Oct 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes task 4 of #3324