Relocate vm.issubclass to obj.is_subclass#3345
Merged
Merged
Conversation
10 tasks
Contributor
|
How about move also |
Member
|
Yeah, I agree with @Snowapril but I'd say we leave it to another PR. @ChJR can you rebase this? |
ChJR
force-pushed
the
feature/relocate_is_subclass
branch
from
62e59d2 to
ba4dace
Compare
Member
|
I think relocating abstract_issubclass and recursive_issubclass is part of this PR. they are internal functions and not expected to be called outside, but visibility is changed to |
Contributor
|
|
Member
youknowone
added
hacktoberfest-accepted
ChJR
force-pushed
the
feature/relocate_is_subclass
branch
from
ba4dace to
2cd6e88
Compare
RustPython#3344 is also related.
youknowone
approved these changes
Oct 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Task 7 of #3324.