Skip to content

Relocate vm._hash to obj.hash#3342

Merged
DimitrisJim merged 2 commits into
RustPython:mainfrom
ChJR:feature/relocate_hash
Oct 19, 2021
Merged

Relocate vm._hash to obj.hash#3342
DimitrisJim merged 2 commits into
RustPython:mainfrom
ChJR:feature/relocate_hash

Conversation

@ChJR

@ChJR ChJR commented Oct 19, 2021

Copy link
Copy Markdown
Contributor

This PR fixes Task 9 of #3324.

@ChJR ChJR force-pushed the feature/relocate_hash branch from 3bd219e to 0d32e1a Compare October 19, 2021 17:10
@DimitrisJim

DimitrisJim commented Oct 19, 2021

Copy link
Copy Markdown
Member

Surprised only 6 places used it! You'll also need to remove vm._hash (after transferring its contents over to obj.hash).

@DimitrisJim DimitrisJim merged commit fcb6551 into RustPython:main Oct 19, 2021
@ChJR ChJR deleted the feature/relocate_hash branch October 20, 2021 15:16
@youknowone youknowone added the hacktoberfest-accepted Ask us to label this to your PR label Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Ask us to label this to your PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants