Skip to content

Relocate vm.set_attr to obj.set_attr#3338

Merged
DimitrisJim merged 1 commit into
RustPython:mainfrom
Limits0x:relocate-set_attrs
Oct 19, 2021
Merged

Relocate vm.set_attr to obj.set_attr#3338
DimitrisJim merged 1 commit into
RustPython:mainfrom
Limits0x:relocate-set_attrs

Conversation

@Limits0x

Copy link
Copy Markdown
Contributor

Fixes Task 2 of #3324

Comment thread vm/src/vm.rs Outdated
@DimitrisJim

Copy link
Copy Markdown
Member

Also, not sure if call_set_attr is actually needed but, lets leave that for another time.

@Limits0x

Copy link
Copy Markdown
Contributor Author

call_set_attr is used in vm/src/builtins/weakproxy.rs:69

@DimitrisJim DimitrisJim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@DimitrisJim DimitrisJim merged commit de41d4c into RustPython:main Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants