Add _statistics module containing _normal_dist_inv_cd#3256
Merged
Conversation
DimitrisJim
reviewed
Oct 9, 2021
aDotInTheVoid
force-pushed
the
stats
branch
2 times, most recently
from
ee9171a to
93e80c4
Compare
Contributor
Author
I thing this is good as one function handles the stats, and the other handles the arg conversion and error. The tests should now pass |
DimitrisJim
requested changes
Oct 9, 2021
aDotInTheVoid
force-pushed
the
stats
branch
2 times, most recently
from
3f0c9e3 to
cab82c9
Compare
DimitrisJim
approved these changes
Oct 11, 2021
DimitrisJim
left a comment
DimitrisJim
left a comment
Member
There was a problem hiding this comment.
lgtm, I'll look into the CI failure, it seems completely unrelated.
Member
|
@DimitrisJim how this one has going? is this need to be rebased? |
Contributor
|
Sorry, I forgot that this PR existed when I trampled on it with #3552. |
Member
|
This version is better structured than current version. I rebased this version on the main branch. |
Member
|
@aDotInTheVoid I am sorry for making you wait for this for so long time. I didn't know this is untracked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3251
Not sure if this needs a test, or if you run the python ones in
Lib/test/test_statistics.pyis enough