Repository navigation
Fix repr for complex numbers involving NaN - #3228
Merged
Merged
Conversation
Member
Contributor
Author
|
Ah, totally missed that there was already a PR up for this. |
Member
|
Yeah, I'll close this for now. If for some reason the other PR doesn't move forward I'll ping you to let you know. Either way, thanks for giving a shot at it! |
Member
|
Let's keep this opened but mark as duplicate. Once either one is merged, we can close both issues. |
Member
|
huh, wasn't aware of duplicate tag tbh, fine by me. |
youknowone
approved these changes
Oct 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
to_lowercase()to format "NaN" as "nan" feels a bit hacky. Happy to make changes if there's a better way.