Repository navigation
Fix test_chr by raising a ValueError on chr(-1) instead of OverflowError - #3223
Merged
Merged
Conversation
DimitrisJim
reviewed
Oct 5, 2021
youknowone
approved these changes
Oct 5, 2021
youknowone
left a comment
youknowone
left a comment
Member
There was a problem hiding this comment.
Thank you for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_chrused to fail onchr(-1)because it would fail to convert the -1 to u32 intry_to_primitive, raising an OverflowError.By changing the received value to a
BigInt, we're able to match chr's docs and always raise aValueErrorif the value is out of range. Note that CPython in turn may raise anOverflowErrorif the argument is too high (platform dependent as it depends on int size), even if it's not documented anywhere.Another option would be to change the received value to
i32.